can not match such string “869759002514931”

[violet701]

the string is just 15 fixed digits witch is start by "86". i have check the pattern "\d{15}", "[0-9]{15}" ,"^[0-9]{15}$" and they all cannot match correctly. what is wrong with it?

[kokke]

Hi @violet701

The quantifier-operator ({number-of-matches}, {min-matches, max-matches) is not supported. I think that's the problem you're experiencing.

As a small hack, maybe you can replace \d{15} with \d+ or \d\d\d\d\d\d\d\d\d\d\d\d\d\d\d...?

[monolifed]

Adding the matching function doesn't seem hard

static int matchquantifier(regex_t p, regex_t* pattern, const char* text, int min, int max)
{
  max -= min;
  while (min > 0 && *text && matchone(p, *text++))
  {
    min--;
  }
  if (min > 0)
    return 0;
  do
  {
    if (matchpattern(pattern, text))
      return 1;
    max--;
  }
  while (max > 0 && *text && matchone(p, *text++));

  return 0;
}

But you'd probably need another array to store mins and maxs

[kokke]

Hi @monolifed

Maybe you could extract the min/max limits from the pattern before calling the matching function, avoiding the need to add extra variables holding the min/max values?

[monolifed]

Right.
https://github.com/monolifed/tiny-regex-c/tree/quantifier

[kokke]

Wow that looks really promising @monolifed :) i will review the code later today / this evening.

I expect i will merge your PR #22 as well :)

[kokke]

@monolifed

I have run a few tests on your quantifier-branch, and I really like it so far.

If you make another PR adding the quantifier functionality (or add it to #22), I will merge it.

[violet701]

oh, it's GREAT!!!

[kokke]

Hey @monolifed - will you make a PR with the quantifier-addition? I think I somehow dropped this on the floor.

I am not sure how to review which additions were made besides the addition of the matchquantifier-function. Maybe you have a better recollection/overview?

[monolifed]

I don't really remember well

[kokke]

😆

I'll try and see if I can get time to clone the branch, pull from master and diff against it. That should do it no? I don't think that branch is any unmergeable changes behind.