Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix relative include in mpi.hpp #120

Open
cwpearson opened this issue Sep 9, 2024 · 1 comment
Open

Fix relative include in mpi.hpp #120

cwpearson opened this issue Sep 9, 2024 · 1 comment

Comments

@cwpearson
Copy link
Collaborator

kokkos-comm/src/KokkosComm/mpi/mpi.hpp

Line 21 in a968a13

#include "../concepts.hpp"

@dssgabriel
Copy link
Collaborator

PR #122 should fix this. If we merge it, I have another PR ready that updates all the includes with the <KokkosComm/...> syntax. I preferred splitting them so not to touch every file at the same time as these are pretty big changes.

Additionally, @cedricchevalier19 mentioned that having relative path includes may improve compilation speed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cwpearson @dssgabriel