Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Render a component without a partial #138

Open
Spone opened this issue Mar 26, 2019 · 1 comment · May be fixed by #163
Open

Render a component without a partial #138

Spone opened this issue Mar 26, 2019 · 1 comment · May be fixed by #163
Labels
enhancement good first issue

Comments

@Spone
Copy link
Collaborator

Spone commented Mar 26, 2019

Drawing inspiration from https://github.com/jensljungblad/components#rendering-components-without-a-partial we could have a render method in our component module, that would return the HTML code for the component.

It would be a nice performance improvement for very simple modules (icons, buttons...)
@xdmx
Copy link

xdmx commented Mar 26, 2019

This is also the approach taken by mountain view, which you may already know as I saw a issue from you a couple of years ago 😄

@jonmast jonmast linked a pull request Jan 26, 2020 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for rendering with block instead of partial jonmast/komponent
2 participants
@Spone @xdmx