Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes the line that contains the incident is not displayed #284

Open
abrugaro opened this issue Jan 27, 2025 · 2 comments
Open

Sometimes the line that contains the incident is not displayed #284

abrugaro opened this issue Jan 27, 2025 · 2 comments
Labels
bug Something isn't working Needs Triage Waiting to be triaged
Milestone

Comments

@abrugaro
Copy link

Image

ENV:

  • Fedora 40
  • Extension v0.0.6
@abrugaro abrugaro added bug Something isn't working Needs Triage Waiting to be triaged labels Jan 27, 2025
@rszwajko
Copy link
Contributor

@abrugaro
Please check if the line number is present in analysis results. The IDE saves raw responses under {workspace}/.vscode/konveyor/analysis_*. Some rules seem to be file-scoped and provide no line number. For better user experience Issue tree view is using fallback to the first line. We could do the same for webview but I'm not sure if it's acceptable in all cases.

@abrugaro
Copy link
Author

Hi @rszwajko, no, the line number wasn't present in the analysis.json file.

Maybe that column could be removed from the view if the line isn't there

@rszwajko rszwajko added this to the v0.1.0 milestone Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Needs Triage Waiting to be triaged
Projects
Status: No status
Development

No branches or pull requests

2 participants