Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow model credentials to be stored in an .env file #89

Closed
jwmatthews opened this issue Mar 21, 2024 · 3 comments
Closed

Allow model credentials to be stored in an .env file #89

jwmatthews opened this issue Mar 21, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@jwmatthews
Copy link
Member

Consider moving to our model coordinates (sensitive) information being stored in a python dotenv file and/or determined from environment.

https://pypi.org/project/python-dotenv/

Related to #85

@jwmatthews jwmatthews added the priority/nextup Issues we want to address soon label Mar 22, 2024
@JonahSussman
Copy link
Contributor

JonahSussman commented Mar 22, 2024

I think the key is automatically loaded from the environment if it is present. I'm looking at https://github.com/konveyor-ecosystem/kai/blob/6049eff2ea1b74d68c75554e8854302100322340/kai/model_provider.py#L47-L52 and https://github.com/konveyor-ecosystem/kai/blob/6049eff2ea1b74d68c75554e8854302100322340/kai/model_provider.py#L105-L113 OpenAI's key check still needs to be implemented if we want, but langchain does that for us

@jwmatthews jwmatthews removed the priority/nextup Issues we want to address soon label Mar 22, 2024
@jwmatthews
Copy link
Member Author

Removed the priority on this. It's not essential to demo flow, usage of environment variables is fine for now.

@JonahSussman JonahSussman added the enhancement New feature or request label Jul 23, 2024
@fabianvf
Copy link
Contributor

Configuration IDE side has matured to the point that this issue is obsolete

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants