Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Add the validation for zip file or unsupported format indicating reason for failure #236

Closed
1 task done
kpunwatk opened this issue May 17, 2024 · 1 comment · Fixed by #269
Closed
1 task done
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Milestone

Comments

@kpunwatk
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Konveyor version

latest

Priority

Major

Current Behavior

Ran an analysis using zip file ex:

$ ./kantra analyze --input=/home/user/sample.daytrader7-master.zip --output=~/output_dir

panic: runtime error: index out of range [0] with length 0 goroutine 1 [running]: github.com/konveyor-ecosystem/kantra/cmd.(*analyzeCommand).RunProviders(0xc00024e780, {0xec4f88, 0xc000035e50}, {0xc0003d3890, 0x10}, {0xc0003d38e0, 0x10}, {0xc0001e1a60, 0x0, 0x0}, ...) /workspace/cmd/analyze.go:799 +0x7b7 github.com/konveyor-ecosystem/kantra/cmd.NewAnalyzeCmd.func2(0xc00029e600, {0xc000296d80?, 0x4?, 0xd61a61?}) /workspace/cmd/analyze.go:171 +0x6e5 github.com/spf13/cobra.(*Command).execute(0xc00029e600, {0xc000296d20, 0x3, 0x3}) /go/pkg/mod/github.com/spf13/[email protected]/command.go:983 +0xabc github.com/spf13/cobra.(*Command).ExecuteC(0x146d580) /go/pkg/mod/github.com/spf13/[email protected]/command.go:1115 +0x3ff github.com/spf13/cobra.(*Command).Execute(...) /go/pkg/mod/github.com/spf13/[email protected]/command.go:1039 github.com/spf13/cobra.(*Command).ExecuteContext(...) /go/pkg/mod/github.com/spf13/[email protected]/command.go:1032 github.com/konveyor-ecosystem/kantra/cmd.Execute() /workspace/cmd/root.go:66 +0x10c main.main() /workspace/main.go:8 +0xf

Expected Behavior

At the end of analysis reason for failure or error.log in the ouptput dir ad output directory remains empty

How Reproducible

Always (Default)

Steps To Reproduce

No response

Environment

- OS:

Anything else?

Jira link too https://issues.redhat.com/browse/MTA-2822

@kpunwatk kpunwatk added kind/bug Categorizes issue or PR as related to a bug. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels May 17, 2024
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added the needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. label May 17, 2024
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning May 17, 2024
@kpunwatk kpunwatk changed the title [BUG] < Add the validation for zip file or unsupported format indicating reason for failure> [BUG] Add the validation for zip file or unsupported format indicating reason for failure May 17, 2024
@dymurray dymurray added this to the v0.5.0 milestone Jun 20, 2024
@dymurray dymurray moved this from 🆕 New to 🔖 Ready in Planning Jun 20, 2024
@eemcmullan eemcmullan self-assigned this Jun 21, 2024
@github-project-automation github-project-automation bot moved this from 🔖 Ready to ✅ Done in Planning Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
Status: ✅ Done
3 participants