From 6d6393b9653779ae20f341a10281026b33613cda Mon Sep 17 00:00:00 2001 From: Emily McMullan Date: Wed, 29 May 2024 16:12:29 -0400 Subject: [PATCH] do not run cleanup for list options Signed-off-by: Emily McMullan --- cmd/analyze.go | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/cmd/analyze.go b/cmd/analyze.go index f72c3a76..a0ae26e8 100644 --- a/cmd/analyze.go +++ b/cmd/analyze.go @@ -127,13 +127,6 @@ func NewAnalyzeCmd(log logr.Logger) *cobra.Command { if val, err := cmd.Flags().GetBool(noCleanupFlag); err == nil { analyzeCmd.cleanup = !val } - // defer cleaning created resources here instead of PostRun - // if Run returns an error, PostRun does not run - defer func() { - if err := analyzeCmd.CleanAnalysisResources(cmd.Context()); err != nil { - log.Error(err, "failed to clean temporary directories") - } - }() if analyzeCmd.listSources || analyzeCmd.listTargets { err := analyzeCmd.ListLabels(cmd.Context()) if err != nil { @@ -142,6 +135,13 @@ func NewAnalyzeCmd(log logr.Logger) *cobra.Command { } return nil } + // defer cleaning created resources here instead of PostRun + // if Run returns an error, PostRun does not run + defer func() { + if err := analyzeCmd.CleanAnalysisResources(cmd.Context()); err != nil { + log.Error(err, "failed to clean temporary directories") + } + }() xmlOutputDir, err := analyzeCmd.ConvertXML(cmd.Context()) if err != nil { log.Error(err, "failed to convert xml rules")