Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 The generic extension need to be split into separate provider extensions. #399

Open
jortel opened this issue Jan 30, 2025 · 1 comment · May be fixed by #401
Open

🐛 The generic extension need to be split into separate provider extensions. #399

jortel opened this issue Jan 30, 2025 · 1 comment · May be fixed by #401
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Milestone

Comments

@jortel
Copy link
Contributor

jortel commented Jan 30, 2025

The generic extension need to be split into separate provider extensions.

Python extension:

kind: Extension
metadata:
  name: python
  namespace: konveyor-tackle
spec:
  addon: analyzer
  container:
    args:
    - --port
    - $(PORT)
    env:
    - name: PORT
      value: ${seq:8000}
    image: quay.io/konveyor/generic-external-provider:latest
    imagePullPolicy: Always
    name: java
    resources:
      limits:
        cpu: 1
        memory: 1Gi
      requests:
        cpu: 1
        memory: 1Gi
  metadata:
    provider:
      address: localhost:$(PORT)
      initConfig:
      - providerSpecificConfig:
          lspServerName: generic
          lspServerPath: /usr/local/bin/pylsp
          workspaceFolders:
          - $(builtin.location)
          dependencyFolders:
          - examples/python/__pycache__ 
          - examples/python/.venv
      name: python
  selector: tag:Language=Python

TypeScript (node.js) extension:

apiVersion: tackle.konveyor.io/v1alpha1
kind: Extension
metadata:
  name: nodejs
  namespace: konveyor-tackle
spec:
  addon: analyzer
  container:
    args:
    - --port
    - $(PORT)
    env:
    - name: PORT
      value: ${seq:8000}
    image: quay.io/konveyor/generic-external-provider:latest
    imagePullPolicy: Always
    name: java
    resources:
      limits:
        cpu: 1
        memory: 1Gi
      requests:
        cpu: 1
        memory: 1Gi
  metadata:
    provider:
      address: localhost:$(PORT)
      initConfig:
        providerSpecificConfig:
          lspServerName: generic
          lspServerPath: /usr/local/bin/typescript-language-server
          lspServerArgs:
          - "--stdio"
          workspaceFolders:
          - $(builtin.location)
      name: nodejs
  selector: tag:Language=TypeScript
@jortel jortel added this to the v0.7.0 milestone Jan 30, 2025
@jortel jortel added this to Planning Jan 30, 2025
@github-project-automation github-project-automation bot moved this to 🆕 New in Planning Jan 30, 2025
@konveyor-ci-bot konveyor-ci-bot bot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 30, 2025
@konveyor-ci-bot
Copy link

This issue is currently awaiting triage.
If contributors determine this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.
The triage/accepted label can be added by org members.

@konveyor-ci-bot konveyor-ci-bot bot added needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Jan 30, 2025
@jortel jortel added kind/bug Categorizes issue or PR as related to a bug. triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/normal Higher priority than priority/minor. Nice to have. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. needs-kind Indicates an issue or PR lacks a `kind/foo` label and requires one. needs-priority Indicates an issue or PR lacks a `priority/foo` label and requires one. labels Feb 5, 2025
@jortel jortel linked a pull request Feb 7, 2025 that will close this issue
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. priority/normal Higher priority than priority/minor. Nice to have. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
Status: 🆕 New
Development

Successfully merging a pull request may close this issue.

1 participant