-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gradle-wrapper.jar checksum verification #39
Comments
/cc @JLLeitschuh |
Relevant issues: gradle/actions#283, gdubw/gng#15 |
Gradle distribution validation might be relevant as well: gradle/actions#286 |
Such improvement should be offered for the Maven and Jbang wrappers as well. |
Of course, if you think it is worth integrating the verification to |
Before doing it on |
The key question here is: do you trust |
What do you think if
gm
verifies the checksum ofgradle/wrapper/gradle-wrapper.jar
file?Of course, it won't make the build completely secure (e.g. a malicious repository could augment
gradlew
to use a different jar for classpath), however it might improve things since text files (e.g. build scripts, batch scripts are easier to review than binary jars).An alternative (or additional) option is to verify the integrity of
gradlew
andgradlew.bat
(e.g. hard-code well-known good checksums)An alternative option is to use
gw
-controlled set ofgradlew
executables (andgradle-wrapper.jar
) sogw
uses a trusted wrapper.The text was updated successfully, but these errors were encountered: