From eaeeef7324fe02772c65ebd5c97a11abf2fdc4a4 Mon Sep 17 00:00:00 2001 From: kortina Date: Mon, 11 May 2020 22:35:32 -0700 Subject: [PATCH] minor edits / comments --- README.md | 4 +--- src/extension.ts | 2 +- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git a/README.md b/README.md index 50dfaa3..dc889be 100644 --- a/README.md +++ b/README.md @@ -66,7 +66,7 @@ Run `npm install` first. ### FAQ - "Autocomplete / Intellisense is not working - why?" - - Make sure that quick suggestions are enabled in Markdown. Put this in settings.json: + - Quick suggestions are not enabled by default in Markdown, so you have to manually `triggerSuggest` OR put this in settings.json: ``` "[markdown]": { "editor.quickSuggestions": true @@ -77,7 +77,6 @@ Run `npm install` first. ### Known Issues -- Filename completion seems to be triggering when not in the `[[` context. - The `ctrl+o` VSCodeVim jumplist shortcut does not return you to the correct place after using "Go to Definition" (`ctrl+]`): https://github.com/VSCodeVim/Vim/issues/3277 (The VSCode `Go Back` command (`ctrl+-`) does work, however.) - This extension sets the `wordPattern` for 'markdown' in order to (1) enable proper completion of relative paths and (2) make it such that if you `cmd+shift+f` on a `#tag` the search will prefill with "#tag" and not just "tag":
`vscode.languages.setLanguageConfiguration('markdown', { wordPattern: /([\#\.\/\\\w_]+)/ });` @@ -89,7 +88,6 @@ Run `npm install` first. - Provide better support for ignore patterns, eg, don't complete `file.md` if it is within `ignored_dir/` - Should we support filename without extension, eg, assume `[[file]]` is a reference to `file.md`? - Should we support links to headings? eg, `file.md#heading-text`? -- Add syntax highlighting and search for `#tags`. See [also](https://stackoverflow.com/questions/60293955/is-cmdshiftf-in-vscode-supposed-to-respect-the-editor-wordseparators-setting) ### Development and Release diff --git a/src/extension.ts b/src/extension.ts index f0979f2..82575f4 100644 --- a/src/extension.ts +++ b/src/extension.ts @@ -318,7 +318,7 @@ const overrideMarkdownWordPattern = () => { export function activate(context: vscode.ExtensionContext) { // console.debug('vscode-markdown-notes.activate'); const md = { scheme: 'file', language: 'markdown' }; - overrideMarkdownWordPattern(); + overrideMarkdownWordPattern(); // still nec to get ../ to trigger suggestions in `relativePaths` mode context.subscriptions.push( vscode.languages.registerCompletionItemProvider(md, new MarkdownFileCompletionItemProvider())