Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rebalance_work accounting overflow/underflow #744

Open
g2p opened this issue Sep 9, 2024 · 1 comment
Open

rebalance_work accounting overflow/underflow #744

g2p opened this issue Sep 9, 2024 · 1 comment

Comments

@g2p
Copy link
Contributor

g2p commented Sep 9, 2024

Noticed this from in-kernel fsck (mount -o verbose,fsck,fix_errors):

bcachefs (fff…): check_allocations...
accounting mismatch for rebalance_work : got 18446744073709538648 should be 207994600, fixing
accounting mismatch for compression lz4: got 1374452 173195248 26964280 should be 1309912 165572536 23486472, fixing
accounting mismatch for compression zstd: got 39845537 4984839376 726231984 should be 39845509 4937226704 719136600, fixing
accounting mismatch for compression incompressible: got 202911546 16270674800 16270674800 should be 202900684 15899707176 15899707176, fixing
done

18446744073709538648 is -12968 cast as u64

@g2p g2p changed the title rebalance_work accounting overflow rebalance_work accounting overflow/underflow Sep 9, 2024
@koverstreet
Copy link
Owner

rebalance_work had an accounting bug that was just fixed - but there must be a bug with compression accounting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants