You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
If the source passed to mark has that tag inserted (even if the content of the ac inline comment marker is modified) it will still show up on the resulting page. If the source mark does not have it, the mark comparison algorithms currently brick over the comments - thus preventing people from being able to comment on generated pages.
It is non-trivial to do a diff while still figuring out where to attach the comment - but it should be possible. If a section was modified beyond recognition the comment could be dropped, but if the diff still had the same text, in theory the item could still be inserted (again - non-trivial). At the very least it could add a dummy location that got inserted near the old location.
The text was updated successfully, but these errors were encountered:
@guoweis-outreach I'm not even sure where to start with such a feature. I'd check what modifications Confluence does to the final HTML that mark sends via API, I suppose Confluence doesn't output it on the page "as is". If it doesn't change the HTML (or at least not much) then we could try to diff and find where the comments are. But this is definitely not a trivial issue as @rhandom already pointed out.
Also, I believe we should check if Confluence has an API that exposes these comments since this ref seems like a unique identifier.
In confluence it is possible to highlight a word, and add a comment. The resulting source then includes items like the following:
If the source passed to mark has that tag inserted (even if the content of the ac inline comment marker is modified) it will still show up on the resulting page. If the source mark does not have it, the mark comparison algorithms currently brick over the comments - thus preventing people from being able to comment on generated pages.
It is non-trivial to do a diff while still figuring out where to attach the comment - but it should be possible. If a section was modified beyond recognition the comment could be dropped, but if the diff still had the same text, in theory the item could still be inserted (again - non-trivial). At the very least it could add a dummy location that got inserted near the old location.
The text was updated successfully, but these errors were encountered: