Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add pattern attb to e-mail fields and remove novalidate #64

Open
kraftbj opened this issue Apr 9, 2013 · 2 comments
Open

Add pattern attb to e-mail fields and remove novalidate #64

kraftbj opened this issue Apr 9, 2013 · 2 comments
Assignees
@kraftbj
Labels
enhancement

Comments

@kraftbj
Copy link
Owner

kraftbj commented Apr 9, 2013

#9 added html5 fun. Set to nonvalidate in 6c14066 to prevent problems. Set to required in #61 , need to add parent attr.
@ghost ghost assigned kraftbj Apr 9, 2013
@kraftbj kraftbj mentioned this issue Apr 15, 2013
Closed
@kraftbj
Copy link
Owner Author

kraftbj commented Apr 15, 2013

Reading up, it sounds like the advice is generally to let the browsers worry about validation. Perhaps instead of pattern rec, have advanced setting checkbox to nonvalidate meant for users who may have internationalized non-latin script domain names.

kraftbj added a commit that referenced this issue Apr 17, 2013
@kraftbj
Removed novalidate. Ref: #64
f3182ba
kraftbj added a commit that referenced this issue Apr 17, 2013
@kraftbj
Require email in HTML5. No pattern attr. Ref: #64. Fixes #61
ff16109
@kraftbj
Copy link
Owner Author

kraftbj commented Apr 17, 2013

Punting issue of setting to add novalidate to future version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@kraftbj kraftbj

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kraftbj