Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check-plugin incompatible with replace directives #33

Open
stevenh opened this issue Aug 28, 2024 · 0 comments · May be fixed by #32
Open

check-plugin incompatible with replace directives #33

stevenh opened this issue Aug 28, 2024 · 0 comments · May be fixed by #32

Comments

@stevenh
Copy link
Contributor

stevenh commented Aug 28, 2024

check-plugin will report a fix needed and non zero exit code for a plug which matches the dependencies of krakend if the dependencies include a module which has been replaced.
stevenh added a commit to stevenh/krakend-cobra that referenced this issue Aug 28, 2024
@stevenh
fix: plugin replace handling
6c32ba4 
Fix getBuildInfo to use dependency replacements if set to ensure that
check plugin doesn't incorrectly report issues for matching replace
directives.

Fixes krakend#33
@stevenh stevenh linked a pull request Aug 28, 2024 that will close this issue
Open
@stevenh stevenh changed the title check-plugin reports invalid status check-plugin incompatible with replace directives Aug 28, 2024
@stevenh stevenh mentioned this issue Aug 28, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: plugin replace handling stevenh/krakend-cobra
1 participant
@stevenh