Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compatibility with jupyter-server 2.x/Jupyterlab 4.x #64

Closed
q-wertz opened this issue Aug 22, 2023 · 9 comments · Fixed by #65
Closed

Compatibility with jupyter-server 2.x/Jupyterlab 4.x #64

q-wertz opened this issue Aug 22, 2023 · 9 comments · Fixed by #65
Labels
help wanted Extra attention is needed

Comments

@q-wertz
Copy link

q-wertz commented Aug 22, 2023

I tried to use jupyterlab-citation-manager but failed to succeed.

Installed the extension in the jupyterlab extension manager, added an API key refreshed the page/restarted the server but no entries can be found.

When I try to install it using poetry I get the following message

Using version ^0.3.2 for jupyterlab-citation-manager

Updating dependencies
Resolving dependencies... (0.1s)

Because no versions of jupyterlab-myst match >2,<2.0.1 || >2.0.1,<3
 and jupyterlab-myst (2.0.0) depends on jupyter-server (>=2.0.1,<3), jupyterlab-myst (>=2,<2.0.1 || >2.0.1,<3) requires jupyter-server (>=2.0.1,<3).
And because jupyterlab-myst (2.0.1) depends on jupyter-server (>=2.0.1,<3), jupyterlab-myst (>=2,<3) requires jupyter-server (>=2.0.1,<3).
Because no versions of jupyterlab-citation-manager match >0.3.2,<0.4.0
 and jupyterlab-citation-manager (0.3.2) depends on jupyter-server (>=1.6,<2), jupyterlab-citation-manager (>=0.3.2,<0.4.0) requires jupyter-server (>=1.6,<2).
Thus, jupyterlab-citation-manager (>=0.3.2,<0.4.0) is incompatible with jupyterlab-myst (>=2,<3).
So, because ads-b simulator depends on both jupyterlab-myst (^2) and jupyterlab-citation-manager (^0.3.2), version solving failed.

Does jupyterlab-citation-manager not work with the jupyter-server v2 but the Jupyterlab Extension Manager just ignores the requirements?

Or is the problem that I'm using jupyterlab version 4.0.5 which seems to collide with e.g.

requires = ["jupyter_packaging~=0.10,<2", "jupyterlab~=3.0"]

"dependencies": {
"@jupyterlab/application": "^3.0.11",
"@jupyterlab/settingregistry": "^3.0.0",

?

@q-wertz q-wertz changed the title Compatibility with jupyter-server 2.x Compatibility with jupyter-server 2.x/Jupyterlab 4.x Aug 22, 2023
@krassowski
Copy link
Owner

Correct, this extension needs to be upgraded to JupyterLab 4.0.

@krassowski krassowski added the help wanted Extra attention is needed label Aug 23, 2023
@q-wertz
Copy link
Author

q-wertz commented Aug 24, 2023

Thanks for clarification :)

@kwilliamszaf
Copy link

I vote for this issue! This would be great to have fixed.

@germannl
Copy link

germannl commented Dec 1, 2023

I am also voting for this issue, would be a great fix.

@krassowski krassowski mentioned this issue Dec 9, 2023
3 tasks
@krassowski
Copy link
Owner

Thank you all for pushing for this one, I opened #64 which does the upgrade but there is some automation issue and I run out of stem for today. Hopefully we can get this to work soon.

@krassowski
Copy link
Owner

krassowski commented Dec 29, 2023

v1.0.0a1 (pre-release) should work well with JupyterLab 4.x. You can install it with:

pip install jupyterlab-citation-manager==1.0.0a1

Please let me know if it works well, in which case I will release it as a final version

@krassowski krassowski pinned this issue Dec 29, 2023
@krassowski
Copy link
Owner

Note: I released another alpha v1.0.0a1) after fixing an issue around adding citations and updated the comment above.

@germannl
Copy link

Thank you for the update, it works well on 4.x for me.

@krassowski
Copy link
Owner

Thanks for getting back to me! v1.0.0 is now up on PyPI: https://pypi.org/project/jupyterlab-citation-manager/1.0.0/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants