Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toggle does nothing upon first click if in Problem panel #1

Open
gobbedy opened this issue Feb 20, 2023 · 5 comments
Open

Toggle does nothing upon first click if in Problem panel #1

gobbedy opened this issue Feb 20, 2023 · 5 comments

Comments

@gobbedy
Copy link

gobbedy commented Feb 20, 2023

Hello,

First off, thank you! I was really hoping exactly this extension existed, and it does. Very nice.

Now to the issue.. When I'm in the Problem panel (or tab? not sure what the right word is) and I click the icon, nothing happens upon the first click.

It only goes to the Terminal panel upon clicking a second time.

Not a big deal, but I'd have expected it to go the terminal panel upon the first click?

Thanks in advance!

@gobbedy
Copy link
Author

gobbedy commented Feb 20, 2023

Oh, I just read your Readme and I see that it's a known issue. No worries! Still a great extensions. Thanks again. Closing as this is a known issue.

@gobbedy gobbedy closed this as completed Feb 20, 2023
@gobbedy
Copy link
Author

gobbedy commented Feb 20, 2023

Sorry if this is a dumb question, but I just realized that the Ctrl+` shortcut (ie the View: Toggle Terminal command) to toggle the Terminal does not exhibit the same issue. That is, when the "Problem" panel is open, typing Ctrl+` jumps straight to the Terminal.

Would it be possible to get the icon to behave exactly like the View: Toggle Terminal command?

@gobbedy gobbedy reopened this Feb 20, 2023
@krish-r
Copy link
Owner

krish-r commented Feb 20, 2023

Hello,

Thanks for your kind comments.

No, not a dumb question. Actually, ctrl +` (View: Toggle Terminal command: workbench.action.terminal.toggleTerminal) was my first choice as well. 😄

Initially, I tried to simply execute that command in the extension. But that command does not seem to toggle the terminal once the focus is on the terminal. (found an old issue discussing about the command behavior).

I also tried to look for the API/how the command is implemented, and unfortunately I couldn't find that either.

So, I have posted my question today on the VS Code discussion section for workarounds. Need to wait and see if there are better solutions to this issue.

Thanks

@gobbedy
Copy link
Author

gobbedy commented Feb 20, 2023

Thanks @krish-r for looking into it!!

@krish-r
Copy link
Owner

krish-r commented Jul 8, 2023

So, I have posted my microsoft/vscode-discussions#478 today on the VS Code discussion section for workarounds. Need to wait and see if there are better solutions to this issue.

Hello,

I received response from VS Code developers, looks like there isn't a workaround as of now.
(I will watch out for updates on microsoft/vscode#117980.)

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants