Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtt config throws error when EDITOR variable is not set #96

Open
husim0 opened this issue Jun 27, 2019 · 1 comment · May be fixed by #113
Open

gtt config throws error when EDITOR variable is not set #96

husim0 opened this issue Jun 27, 2019 · 1 comment · May be fixed by #113

Comments

@husim0
Copy link

husim0 commented Jun 27, 2019

Hello :-)

On my config, EDITOR is not set.

$ gtt config
child_process.js:207
    throw new ERR_INVALID_ARG_VALUE('args', arguments[pos]);
    ^

TypeError [ERR_INVALID_ARG_VALUE]: The argument 'args' is invalid. Received { env:
   { GS_LIB: '/home/hugo/.fonts',
     KDE_FULL_SESSION: 'true',
     LS_COLORS:
      'no=00:fi=00:di=01;34:ln=00;36:pi=...
    at Object.execFile (child_process.js:207:11)
    at Object.childProcess.execFile (pkg/prelude/bootstrap.js:1420:30)
    at Object.exec (child_process.js:148:18)
    at childProcess.exec (pkg/prelude/bootstrap.js:1434:26)
    at open (/snapshot/gitlab-time-tracker/node_modules/open/lib/open.js:58:10)
    at Function.open (/snapshot/gitlab-time-tracker/src/include/filesystem.js:0:0)
    at Object.<anonymous> (/snapshot/gitlab-time-tracker/src/gtt-config.js:0:0)
    at Module._compile (pkg/prelude/bootstrap.js:1254:22)
    at Object.Module._extensions..js (internal/modules/cjs/loader.js:711:10)
    at Module.load (internal/modules/cjs/loader.js:610:32)

Setting EDITOR works.

EDITOR=nano gtt config
@Pablohn26
Copy link
Contributor

Pablohn26 commented Jun 4, 2020

Using docker version EDITOR variable is set here and this issue cannot be reproduced. This issue shows up when you are using compiled version gtt-linux in distros like Ubuntu 18.04 that does not have by default environment variables VISUAL and EDITOR of this commit.

@Pablohn26 Pablohn26 linked a pull request Jun 5, 2020 that will close this issue
@cgdobre cgdobre linked a pull request Jun 7, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants