Skip to content
This repository has been archived by the owner on Jul 31, 2020. It is now read-only.

Fix error handling in script #9

Open
kristianfreeman opened this issue Mar 9, 2020 · 1 comment
Open

Fix error handling in script #9

kristianfreeman opened this issue Mar 9, 2020 · 1 comment
Milestone
v1.1

Comments

@kristianfreeman
Copy link
Owner

When a selector lookup or something similar fails inside of the code (see https://github.com/totemprotocol/roam-backup/runs/496115224?check_suite_focus=true#step:5:17 for an example), the script is catching the error and making it so that the workflow step returns as successful.

https://github.com/signalnerve/roam-backup/blob/master/index.js#L108
@kristianfreeman kristianfreeman added this to the v1.1 milestone Mar 9, 2020
Stvad added a commit to Stvad/roam-backup that referenced this issue Mar 21, 2020
@Stvad
Re-throw error after capturing snapshot kristianfreeman#9
2ec8f9e
Stvad added a commit to Stvad/roam-backup that referenced this issue Mar 21, 2020
@Stvad
Re-throw error after capturing snapshot kristianfreeman#9
4d629c2
@Stvad
Copy link

Stvad commented Mar 21, 2020

have provisional fix for this in my fork

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.1
Development

No branches or pull requests
2 participants
@Stvad @kristianfreeman