Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of OnFastChooseListener #20

Open
KlutzyBubbles opened this issue May 12, 2018 · 2 comments
Open

Removal of OnFastChooseListener #20

KlutzyBubbles opened this issue May 12, 2018 · 2 comments

Comments

@KlutzyBubbles
Copy link

Don't see the point in it, i created a fork located https://github.com/KlutzyBubbles/colorpicker/tree/master/colorpicker-library/src/main/java/petrov/kristiyan/colorpicker which contains the changes to remove the interface.

Reasoning: i was developing with the library and found that

  1. the method within the interface was incorrectly named (setOnFastChangeListener instead of onFastChange)
  2. It was extremely frustrating when creating similar code to have to rename the method and the interface for the exact same code (for setting color variables)

An option IF you really dont want to remove the OnFastChangeListener is to make it the same method names as both interfaces were made to provide the same data for the same output just via a different path.

Wanted to create an issue for this before i make a pull request.

@kristiyanP
Copy link
Owner

I would gladly accept a pull request with a refactor for the method name as i think the method is fairly necessary.

@mustafamn
Copy link

i m getting an extra 2 row while i did not apply the color..???

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants