Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to cache docker image #6

Open
halvardssm opened this issue May 11, 2020 · 4 comments
Open

How to cache docker image #6

halvardssm opened this issue May 11, 2020 · 4 comments

Comments

@halvardssm
Copy link

Hi! I find your action really useful, but the build time lasts quite long since it downloads the image on each build. Is there a way to cache the image between builds?

Thanks!

@nyaaao
Copy link

nyaaao commented Aug 5, 2020

downloaded images are cached (somewhat) but here the problem is that the image is built anew each run. One way to fix this is build and upload the image to some registry, like Docker Hub, then update the image field in the action.yml.
For reference: https://docs.github.com/en/actions/creating-actions/metadata-syntax-for-github-actions#example-using-public-docker-registry-container

@nyaaao
Copy link

nyaaao commented Aug 5, 2020

also @krizzu, I believe you don't have to pass inputs explicitly via args, they get passed down to your code anyway

@krizzu
Copy link
Owner

krizzu commented Aug 5, 2020

To speed up this action, one can use action caching. Another way would be to have this docker image uploaded in Docker Hub.

@nyaaao what args are you referring to?

@nyaaao
Copy link

nyaaao commented Aug 5, 2020

@krizzu I was referring to these https://github.com/Krizzu/eslint-check-action/blob/master/action.yml#L23-L27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants