feat: update selector role conventions

kroma-network · Mar 15, 2024 · a9fbba3 · a9fbba3
1 parent 9193038
commit a9fbba3
Show file tree

Hide file tree

Showing 3 changed files with 36 additions and 6 deletions.
diff --git a/contracts/access/SelectorRoleControlUpgradeable.sol b/contracts/access/SelectorRoleControlUpgradeable.sol
@@ -21,16 +21,26 @@ interface IMulticall {
     function multicall(bytes[] calldata data) external returns (bytes[] memory results);
 }
 
-interface ISelectorRoleControl is IAccessControlEnumerable, IPausable {
-    function grantSelectorRole(bytes4 selector, address account) external;
+interface ISelectorControl is IAccessControl {
+    function hasSelectorRole(bytes4 role, address account) external view returns (bool);
 
-    function revokeSelectorRole(bytes4 selector, address account) external;
+    function getSelectorRoleAdmin(bytes4 role) external view returns (bytes32);
 
-    function pause() external;
+    function grantSelectorRole(bytes4 role, address account) external;
 
-    function unpause() external;
+    function revokeSelectorRole(bytes4 role, address account) external;
+
+    function renounceSelectorRole(bytes4 role, address callerConfirmation) external;
 }
 
+interface ISelectorControlEnumerable is IAccessControlEnumerable, ISelectorControl {
+    function getSelectorRoleMember(bytes4 role, uint256 index) external view returns (address);
+
+    function getSelectorRoleMemberCount(bytes4 role) external view returns (uint256);
+}
+
+interface ISelectorRoleControl is ISelectorControlEnumerable, IPausable {}
+
 contract SelectorRoleControlUpgradeable is
     Initializable,
     ISelectorRoleControl,
@@ -72,4 +82,24 @@ contract SelectorRoleControlUpgradeable is
     function unpause() public virtual override onlyAdmin {
         _unpause();
     }
+
+    function hasSelectorRole(bytes4 role, address account) external view override returns (bool) {
+        return hasRole(role, account);
+    }
+
+    function getSelectorRoleAdmin(bytes4 role) external view override returns (bytes32) {
+        return getRoleAdmin(role);
+    }
+
+    function renounceSelectorRole(bytes4 role, address callerConfirmation) external override {
+        return renounceRole(role, callerConfirmation);
+    }
+
+    function getSelectorRoleMember(bytes4 role, uint256 index) external view override returns (address) {
+        return getRoleMember(role, index);
+    }
+
+    function getSelectorRoleMemberCount(bytes4 role) external view override returns (uint256) {
+        return getRoleMemberCount(role);
+    }
 }
diff --git a/hardhat.config.ts b/hardhat.config.ts
@@ -5,6 +5,7 @@ import "./tasks/utils";
 
 import "hardhat-tracer";
 import "solidity-coverage";
+import "hardhat-contract-sizer";
 
 import "./tasks/namespace-slot";
 

diff --git a/package.json b/package.json
@@ -2,7 +2,6 @@
   "name": "eco-lib",
   "version": "1.0.0",
   "license": "MIT",
-
   "devDependencies": {
     "@nomicfoundation/hardhat-chai-matchers": "^2.0.0",
     "@nomicfoundation/hardhat-ethers": "^3.0.0",