Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validation Needed to Restrict Auto and Recreate Modes for Namespace Experiments #1462

Open
shekhar316 opened this issue Jan 16, 2025 · 0 comments · Fixed by #1463
Open

Validation Needed to Restrict Auto and Recreate Modes for Namespace Experiments #1462

shekhar316 opened this issue Jan 16, 2025 · 0 comments · Fixed by #1463
Assignees
Labels
bug Something isn't working

Comments

@shekhar316
Copy link
Contributor

Describe the bug

Auto and recreate modes are currently allowed for namespace experiments, which is not supported. A validation needs to be added to restrict the use of auto or recreate modes for namespace experiments.

How to reproduce it

Currently, namespace experiments mistakenly allow the selection of "auto" or "recreate" modes, even though these modes are not supported. This leads to unexpected behavior.

  1. Create an experiment using a namespace JSON.
  2. Set the mode to either "auto" or "recreate."

Expected behavior

If the mode is set to "auto" or "recreate," the following response should be returned:

{
  "message": "auto or recreate mode is not supported for namespace experiment.",
  "httpcode": 400,
  "documentationLink": "",
  "status": "ERROR"
}
@shekhar316 shekhar316 added the bug Something isn't working label Jan 16, 2025
@shekhar316 shekhar316 added this to the Kruize 0.4 Release milestone Jan 16, 2025
@shekhar316 shekhar316 self-assigned this Jan 16, 2025
@shekhar316 shekhar316 moved this to Under Review in Monitoring Jan 16, 2025
@shekhar316 shekhar316 moved this from Under Review to Done in Monitoring Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant