Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Canary Rollout From KF-Serving Web App UI #2

Open
sriharan16 opened this issue Jul 17, 2021 · 5 comments · May be fixed by #16
Open

Canary Rollout From KF-Serving Web App UI #2

sriharan16 opened this issue Jul 17, 2021 · 5 comments · May be fixed by #16

Comments

@sriharan16
Copy link

/kind feature

Describe the solution you'd like
I was trying the KF-Serving model web app and tried to deploy a canary rollout that was working using Kubectl commands but I don’t see any option for it in the model web app UI.

Here the web app supports the YAML structure and uses the v1beta1 API. So we deployed a default model version and it got successfully deployed and changes reflected in web app. Now we wanted to deploy a canary model which needs the YAML to be modified with canaryTrafficPercent value which looks not possible from UI as we don’t see any edit option in UI. Also when we rollout the canary from UI as we do via kubectl I'm getting an error saying model with name 'my-model' already exists. I would like to have an edit feature or canary rollout feature from the UI which makes it easy for everyone to work with.

The document I followed was, https://github.com/kubeflow/kfserving/tree/master/docs/samples/v1beta1/rollout

Anything else you would like to add:
I see two ways to achieve this part.

  • Adding edit feature in the already deployed model for new roll out.
  • Similar to kubectl where default and canary rollout are independent where just that the model name is similar. We can something similar to that either inside model specific page or on the list model page.

@kimwnasptd I hope this should be helpful to track and develop the same.

One more request is when developing a new feature please update the doc so we can utilize the same, because for python SDK docs we have v1alpha2 examples that are not supported post-kf-serving 0.6.0 version.

@sriharan16
Copy link
Author

Hi, Any update on this as this is stale for about 2 weeks.

@yuzisun yuzisun transferred this issue from kserve/kserve Sep 23, 2021
@markwinter
Copy link
Member

@sriharan16

I will work on this soon!

I think there will probably be two separate features?

  1. Edit a model server
  • This is to edit things like autoscaling settings, resource settings etc.
  1. Canary rollout
  • This will allow you to just set the new storageUri and the traffic percentage

Or maybe it should all be one Edit Model Server form, I'm not sure yet

@sriharan16
Copy link
Author

Hi,
That's great news. It can be either way as you said.

Just to add, the functionality was expected to perform the rollout present in this doc via the model server UI similar to how we do it in the CLI using .yaml files and kubectl. If this is possible it will be the best part of the Web APP UI.

@markwinter
Copy link
Member

markwinter commented Nov 2, 2021

FYI I am working on this now.

I will add an Edit button that loads the existing YAML which you can edit to change the storageUri and add the canaryTrafficPercent

This should be a quick solution that satisfies most use-cases

Later on I can make a nicer UI

@markwinter markwinter linked a pull request Nov 3, 2021 that will close this issue
@javen218
Copy link

javen218 commented Aug 3, 2022

Does models-web-app v0.8.0 already support canary rollout? If not, is there any plan? @markwinter @kimwnasptd
I want to know what release could has this basic and really really iportant feature!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants