Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove object files from the repo #1817

Open
kranurag7 opened this issue Jul 25, 2024 · 0 comments
Open

remove object files from the repo #1817

kranurag7 opened this issue Jul 25, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@kranurag7
Copy link
Member

The main focus of this proposal is that we stop storing object files in our repository anymore. This is insecure and we want to avoid it.

Upon looking a bit into building the object files on an ubuntu 22.04 machine, I found out that we depend on these system dependencies.

  • sudo apt install gcc libelf-dev clang llvm libbpf-dev linux-tools-common linux-tools-$(uname -r) linux-headers-$(uname -r) -y
$ git diff
diff --git a/KubeArmor/Makefile b/KubeArmor/Makefile
index d550ec8c..39f34657 100644
--- a/KubeArmor/Makefile
+++ b/KubeArmor/Makefile
@@ -189,3 +189,8 @@ ifeq ($(KUBEARMOR_PID), )
 endif
        sudo $(DLV_EXEC) attach $(KUBEARMOR_PID) --headless -l=:$(DLV_LPORT) --log --api-version 2 $(CURDIR)
 
+.PHONY: object-files
+object-files:
+       cd enforcer/bpflsm; go generate
+       cd utils/bpflsmprobe; go generate
+       cd BPF; make

I think if we proceed with diff above and keep everything as it is then we will be able to remove the object files from the repository. We will ensure that we run the make object-files target in CI before we execute the docker build

@kranurag7 kranurag7 added the enhancement New feature or request label Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant