Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Done!

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Done!

The output should be something like in following order
if pod.status == runinng {
print(" verifying kubearmor functionality")
} else {
print(" failed to verify kubearmor functionality, kubearmor daemonset failed to start" , pod. status.reason)
}
cc: @daemon1024

Thanks for the quick PR. There's no point of having the Verifiying logic run if the pod is in CrashLoopBackOff. We should skip that check if the Pod is not running

Done!

The output should be something like in following order if pod.status == runinng { print(" verifying kubearmor functionality") } else { print(" failed to verify kubearmor functionality, kubearmor daemonset failed to start" , pod. status.reason) } cc: @daemon1024

Resolved!

@daemon1024 Please review

@daemon1024 @Aryan-sharma11 Please review!

@Aryan-sharma11 @daemon1024 Is this PR still relevant?

Yes this is still relevant.

Sorry, I am not sure how the earlier pings got missed

No issues, we can restart the work!

Let me try it locally, the changes look mostly great. Can you squash the commits meanwhile?

Sorry for this, as this was very old PR, cleaning this PR

Please don't apologise, our fault for not reviewing it for long.
Take your time, Always appreciate your contribution

Please don't apologise, our fault for not reviewing it for long. Take your time, Always appreciate your contribution

Thanks for your time, have cleaned this PR. Please see if it is ready to merge. To test it you might have to create a situation where pods are in some error or waiting state (probably by increasing the load and reducing the available resources for the pods)