Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ws): add GET WS yaml to backend #209

Open
wants to merge 4 commits into
base: notebooks-v2
Choose a base branch
from
Open

feat(ws): add GET WS yaml to backend #209

wants to merge 4 commits into from

Conversation

mohamedch7
Copy link

@mohamedch7 mohamedch7 commented Feb 13, 2025 •
edited
Loading

Closes #200

HTTP endpoint response:

image

HTTP endpoint response converted to YAML:

image

@google-oss-prow Google OSS Prow
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

ederign
ederign suggested changes Feb 27, 2025
View reviewed changes
Copy link
Member

@ederign ederign left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will probably need to change the call to that repository.

workspaces/backend/api/workspace_yaml_handler.go Outdated
@@ -0,0 +1,67 @@
// Copyright 2024.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just for the sake of aesthetics, could you please add a block comment instead of line comment?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

workspaces/backend/api/workspace_yaml_handler.go
return
}

workspace, err := a.repositories.Workspace.GetWorkspace(r.Context(), namespace, workspaceName)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mohamedch7 I would like to confirm with @paulovmr what we are doing here.

As far as I understand, what we are planning for the UI is having a "RAW" YAML representation of the workspace and not the models.Workspace object (that we translate)

@paulovmr can you please confirm that what we want is a way to see the RAW Workspace YAML there?

@ederign
Copy link
Member

ederign commented Feb 27, 2025

/assign @ederign

@thesuperzapper thesuperzapper changed the title feat(ws): Add GET workspace yaml endpoint feat(ws): add GET WS yaml to backend Feb 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederign ederign ederign requested changes

@kimwnasptd kimwnasptd Awaiting requested review from kimwnasptd

@thesuperzapper thesuperzapper Awaiting requested review from thesuperzapper

Assignees

@ederign ederign

Labels
size/L
Projects
Kubeflow Notebooks
Status: Needs Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mohamedch7 @ederign