Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve(ws): add controller-image parameter to e2e tests #218

Open
wants to merge 1 commit into
base: notebooks-v2
Choose a base branch
from

Conversation

etirelli
Copy link

Adding support for a command line parameter to set which image to use for e2e tests.

To run the tests with a given image, use the IMG parameter:

make test-e2e IMG=<some-registry>/workspace-controller:tag

Please note that if not defined, the default for e2e tests is now:

IMG ?= controller:latest

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -1,5 +1,6 @@
# Image URL to use all building/pushing image targets
IMG ?= controller:latest
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was not sure if I should change the default here to ghcr.io/kubeflow/notebooks/workspace-controller:latest to stay consistent with the previous e2e test behaviour or even create a separate parameter for it. Let me know please if you prefer that I do that.

@ederign
Copy link
Member

ederign commented Feb 27, 2025

/assign @thesuperzapper

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Needs Triage
Development

Successfully merging this pull request may close these issues.

3 participants