Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix make deploy and install #2412

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

nabuskey
Copy link
Contributor

Purpose of this PR

Currently make deploy and make install-crd are broken. This PR aims to fix it.

fixes: #2386

Proposed changes:

  • For make deploy, I followed the e2e-test logic where it deploys using the helm chart directory and the value file for CI.
  • For make install-crd, I am using kubectl replace instead of apply to avoid overloading annotations.
  • I've also updated the default kind node image to v1.29.12 because v1.29.3 does not exist anymore.

Change Category

  • Bugfix (non-breaking change which fixes an issue)
  • Feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that could affect existing functionality)
  • Documentation update

Rationale

Checklist

  • I have conducted a self-review of my own code.
  • I have updated documentation accordingly.
  • I have added tests that prove my changes are effective or that my feature works.
  • Existing unit tests pass locally with my changes.

Additional Notes

Example outputs.

$ make deploy
NAME: spark-operator
LAST DEPLOYED: Tue Jan 28 21:02:43 2025
NAMESPACE: default
STATUS: deployed
REVISION: 1
TEST SUITE: None
$ k get pods
NAME                                         READY   STATUS    RESTARTS   AGE
spark-operator-controller-86978864c7-nvdv5   1/1     Running   0          3m48s
spark-operator-webhook-6c477b69d6-gb8kj      1/1     Running   0          3m48s
$ make undeploy
release "spark-operator" uninstalled

Signed-off-by: Manabu McCloskey <[email protected]>
@nabuskey
Copy link
Contributor Author

hmm no idea why e2e test for v1.28.13 failed. I just run it locally and it did pass.

Signed-off-by: Manabu McCloskey <[email protected]>
Signed-off-by: Manabu McCloskey <[email protected]>
Copy link
Contributor

@vara-bonthu vara-bonthu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

Thanks for this PR @nabuskey !

@jacobsalway @ChanYiLin @ImpSy

Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vara-bonthu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

install-crd make command does not work
2 participants