Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add client TLS flags for AWS provider #5026

Open
cavdhut opened this issue Jan 22, 2025 · 6 comments · May be fixed by #5097
Open

Add client TLS flags for AWS provider #5026

cavdhut opened this issue Jan 22, 2025 · 6 comments · May be fixed by #5097
Assignees
Labels
area/provider/aws Issues or PRs related to aws provider help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.

Comments

@cavdhut
Copy link

cavdhut commented Jan 22, 2025

We utilize the AWS provider with external DNS running behind a forward proxy, which requires presenting client TLS certificates during requests. According to the documentation at https://github.com/kubernetes-sigs/external-dns/blob/master/docs/flags.md, it appears that specifying TLS client certificates and keys via --tls-client-cert and --tls-client-cert-key input arguments is supported. However, upon further investigation of the code, it seems that the AWS provider does not currently support this.

We would like to request the addition of this support for the AWS provider. If this is acceptable, I can look into creating a pull request (PR) to implement this feature.

@cavdhut cavdhut added the kind/feature Categorizes issue or PR as related to a new feature. label Jan 22, 2025
@ivankatliarchuk
Copy link
Contributor

Hi @cavdhut

Sure go ahead.

/help

@k8s-ci-robot
Copy link
Contributor

@ivankatliarchuk:
This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed
by commenting with the /remove-help command.

In response to this:

Hi @cavdhut

Sure go ahead.

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Jan 22, 2025
@ivankatliarchuk
Copy link
Contributor

/help
/area provider/aws

@k8s-ci-robot k8s-ci-robot added the area/provider/aws Issues or PRs related to aws provider label Feb 1, 2025
@hjoshi123
Copy link
Contributor

@cavdhut are you working on this? If not I can take it up

@cavdhut
Copy link
Author

cavdhut commented Feb 11, 2025

@hjoshi123 Please take it. I did not get chance to look into this.

@hjoshi123
Copy link
Contributor

/assign

@hjoshi123 hjoshi123 linked a pull request Feb 15, 2025 that will close this issue
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/provider/aws Issues or PRs related to aws provider help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. kind/feature Categorizes issue or PR as related to a new feature.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants