-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incorrect conformance tests and reporting for Mesh? #3581
Comments
/area mesh |
/label release-blocker I believe some form of this should be a blocker. If we are unable to do the framework changes by 1.3 I'd hope the reporting would at least change for mesh to not report more features than tested. |
@LiorLieberman: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/label release-blocker |
@robscott: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
What happened:
Looking into our conformance reports and tests for Mesh, I see features being reported as "supported" but suspect we are not even testing them. Taking istio as an example.
HTTPRoutePathRewrite
as an example, we can see that the test for this feature only deploys an HTTPRoute with a Gateway as a parentRef and not a Service.What you expected to happen:
We should test every feature thats applicable to mesh (should be most of the features if we stick to the vision) with Service as a parentRef in addition to Gateway.
Ideally we should address this as a framework change with support to exclude features as opposed to add this functionality to every test. The Service-as-a-parentRef tests should only be running if the implementation indicated that they support the MESH profile.
/area conformance
/cc @howardjohn @robscott @youngnick @mlavacca @kflynn @shaneutt @mikemorris
The text was updated successfully, but these errors were encountered: