-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax validation rules enforcing immutability of replicated jobs #579
Comments
When using ResourceFlavors with nodeLabels, Kueue will inject node selectors to the Pod. When using cluster-autoscaler ProvisioningRequest, Kueue will inject an annotation to the Pod template. These fields should be mutable, especially if the Jobset is suspended or is just about to transition to suspend=false. |
Planning on including this in a patch release early next week. cc @ahg-g I think a patch release is fine, since the validation is being relaxed (not increased) so we won't break any running workloads running on v0.5.x and upgrading to this patch (v0.5.2). Alternatively we can include this in v0.6.0, which will be ready soon as well, after we do some manual testing of #537 (targeting June 1st). |
I would vote to put it in a new release. It’s not really something I would think to be included in a patch release. |
Reduced scope of bug specifically to replicatedJob pod template since #529 already exists |
I reduced the scope of the changes to be the validation fix only, and postponed the elastic jobset support to be included in v0.6.0. So I think we can go ahead and do a patch release for this. |
What would you like to be added:
Relax validation rules enforcing immutability of replicated jobs. Specifically:
.spec.replicatedJobs[*].spec.template.spec.template
(job podTemplateSpec, to add annotations, taint tolerations, etc)Why is this needed:
DWS compatibility with JobSet. cc @alculquicondor for more context
The text was updated successfully, but these errors were encountered: