Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kind build node-image supports skipping kubernetes build artifacts, only build image from docker output #1616

Closed
zjj2wry opened this issue May 21, 2020 · 5 comments
Closed

kind build node-image supports skipping kubernetes build artifacts, only build image from docker output #1616

zjj2wry opened this issue May 21, 2020 · 5 comments
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.

Comments

@zjj2wry
Copy link

zjj2wry commented May 21, 2020

What would you like to be added:

kind build node-image --type=none

Why is this needed:
@zjj2wry zjj2wry added the kind/feature Categorizes issue or PR as related to a new feature. label May 21, 2020
@BenTheElder
Copy link
Member

huh? I don't understand the request.

@BenTheElder
Copy link
Member

do you mean #381 ?

@BenTheElder BenTheElder added the triage/needs-information Indicates an issue needs more information in order to work on it. label May 21, 2020
@zjj2wry
Copy link
Author

zjj2wry commented May 21, 2020 •
edited
Loading

I understand that the behavior of kind build node-image will always execute some commands like build/run.sh make KUBE_BUILD_PLATFORMS = linux/amd64, but I want to use the existing binary under the _output / dockerized directory, only build node image instead of compile + build node image

@BenTheElder
Copy link
Member

we need to ensure the right things are built at the same commit and be aware of where they were built to etc.

#381 concerns consuming pre-existing built output.

@BenTheElder BenTheElder added triage/duplicate Indicates an issue is a duplicate of other open issue. and removed kind/feature Categorizes issue or PR as related to a new feature. triage/needs-information Indicates an issue needs more information in order to work on it. labels May 21, 2020
@BenTheElder
Copy link
Member

the build system produces release tarballs, this will be covered by #381

the set of targets we need will change with time, but it should always be a subset of make quick-release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@BenTheElder @zjj2wry