Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usage with CI? #23

Open
alexzielenski opened this issue May 5, 2023 · 13 comments
Open

Usage with CI? #23

alexzielenski opened this issue May 5, 2023 · 13 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.

Comments

@alexzielenski
Copy link
Contributor

readme could use a guide on how to integrate kubectl-validate into your CI system

@alexzielenski alexzielenski added the good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. label May 5, 2023
@clearnicki
Copy link
Contributor

If this is available to work on - I can help with this as well.

/assign

@apelisse
Copy link
Contributor

Happy to help @clearnicki if you need, let me know what I can do to be useful :-)

@clearnicki
Copy link
Contributor

@alexzielenski I can start working on this today - is there anything specific that you would like to be included?

@apelisse - yea I would love some help, I can reach out to you on slack!

@clearnicki
Copy link
Contributor

Spoke with @apelisse - this seems more involved than I have time for right now.

/unassign

@rahul-theorem
Copy link

rahul-theorem commented Jun 6, 2023

This looks very promising for our CI automation - we've been looking at Kubeconform but we'd rather integrate a project that's already part of a K8s SIG. Would be interested in contributing to this after we finish our initial integration (we're planning on running this in GitHub Actions)

Minimally, publishing release binaries will be helpful for this to be walk-up usable - we could contribute that to this repo (or to get started faster we can start publishing it in an internal mirror)

@apelisse
Copy link
Contributor

apelisse commented Jun 6, 2023

Minimally, publishing release binaries will be helpful for this to be walk-up usable

That's good to know, please feel free to share anything that prevents you from integrating. May I ask what CI system you use? We could publish binary, but also a docker image I think would be nice. We're also planning on having a github action to easily run it. In the mean-time, a go install ... should work wonders for most people.

@eyarz
Copy link
Contributor

eyarz commented Jul 5, 2023

I opened a PR with a naive implantation of kubectl-validate with github workflow and docker. This can be a good workaround until this project will get an official GitHub Action (published on the marketplace) and a Docker image (published on a registry).

I can help with that, but it will be impossible to do it without having some access permissions to this project to set it up.

@MaGaroo
Copy link
Contributor

MaGaroo commented Jul 5, 2023

Thank you @eyarz :)

Also, I think I can help with this task too. Just let me know if you think I can do anything.

@apelisse
Copy link
Contributor

apelisse commented Jul 5, 2023

I can help with that, but it will be impossible to do it without having some access permissions to this project to set it up.

Let's see if we can make that work. Ping me on slack!

@apelisse
Copy link
Contributor

apelisse commented Jul 5, 2023

This can be a good workaround until this project will get an official GitHub Action (published on the marketplace) and a Docker image (published on a registry)

I'm interested in both, I'm looking in the latter right now. Looks like we should be able to publish the docker image in registry.k8s.io!

@MPV
Copy link

MPV commented May 29, 2024

This would be really helpful, as just running go install sigs.k8s.io/kubectl-validate@latest in CI currently takes more than 2.5 minutes to download.

I imagine either a binary or a docker image would be a lot quicker.

@eddycharly
Copy link
Contributor

@MPV you can download the binary from the release page https://github.com/kubernetes-sigs/kubectl-validate/releases/tag/v0.0.4

@crandles
Copy link

crandles commented Oct 9, 2024

Here (#142) is an implementation of validation errors as lint output. You can use this with reviewdog to post PR comments.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines.
Projects
None yet
Development

No branches or pull requests

9 participants