Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ar] Netlify preview needs to be configured for the Arabic branch #46087

Closed
mboukhalfa opened this issue Apr 30, 2024 · 10 comments
Closed

[ar] Netlify preview needs to be configured for the Arabic branch #46087

mboukhalfa opened this issue Apr 30, 2024 · 10 comments
Labels
area/localization General issues or PRs related to localization kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@mboukhalfa
Copy link
Member

mboukhalfa commented Apr 30, 2024

This is a Feature Request

As Kubernetes Arabic localizer, I propose configuring Netlify preview on the Arabic branch (dev-1.29-ar.1) to facilitate the previewing of changes, ensure successful website building, and assist reviewers in examining the content.

The dev-1.29-ar.1 branch has been created specifically to host the Arabic localization efforts. The progress of this localization is being tracked through the following issues:

#44682
#37546

What would you like to be added

Configure Netlify preview specifically for the dev-1.29-ar.1 branch.

Why is this needed

It is essential to have Netlify preview for the Arabic branch to facilitate the review process. This preview functionality will be particularly useful for identifying and addressing CSS issues related to right-to-left (RTL) layout, as Arabic is the first RTL language supported. For example, issues such as those outlined in the following PR and issue:

#46042
#45077

Comments

The Netlify preview will enable contributors and reviewers to visualize and discuss these issues directly within the context of pull requests, enhancing the efficiency and effectiveness of the localization efforts.

Slack discussion : https://kubernetes.slack.com/archives/C1J0BPD2M/p1714297094044239

@mboukhalfa mboukhalfa added the kind/feature Categorizes issue or PR as related to a new feature. label Apr 30, 2024
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Apr 30, 2024
@seokho-son
Copy link
Member

/triage accepted

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 30, 2024
@seokho-son
Copy link
Member

PTAL @sftim

@sftim
Copy link
Contributor

sftim commented Apr 30, 2024

@kubernetes/sig-docs-leads FYI

@sftim
Copy link
Contributor

sftim commented Apr 30, 2024

/area localization

@k8s-ci-robot k8s-ci-robot added the area/localization General issues or PRs related to localization label Apr 30, 2024
@reylejano
Copy link
Member

I've added a Netlify site that deploys dev-1.29-ar.1, please check if a preview is available on an updated or new PR

@reylejano
Copy link
Member

I've added a Netlify site that deploys dev-1.29-ar.1, please check if a preview is available on an updated or new PR

For reference, in Netlify I've named this site kubernetes-io-ar-staging

@mboukhalfa
Copy link
Member Author

I've added a Netlify site that deploys dev-1.29-ar.1, please check if a preview is available on an updated or new PR

updated this PR and waiting for the build #46042

@mboukhalfa
Copy link
Member Author

Netlify preview is working now on PRs targeting the branch dev-1.29-ar.1
Thanks @reylejano
We can close this issue now

@seokho-son
Copy link
Member

/close

@k8s-ci-robot
Copy link
Contributor

@seokho-son: Closing this issue.

In response to this:

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/localization General issues or PRs related to localization kind/feature Categorizes issue or PR as related to a new feature. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

5 participants