-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ar] Netlify preview needs to be configured for the Arabic branch #46087
Comments
/triage accepted |
PTAL @sftim |
@kubernetes/sig-docs-leads FYI |
/area localization |
I've added a Netlify site that deploys |
For reference, in Netlify I've named this site |
updated this PR and waiting for the build #46042 |
Netlify preview is working now on PRs targeting the branch |
/close |
@seokho-son: Closing this issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This is a Feature Request
As Kubernetes Arabic localizer, I propose configuring Netlify preview on the Arabic branch (
dev-1.29-ar.1
) to facilitate the previewing of changes, ensure successful website building, and assist reviewers in examining the content.The
dev-1.29-ar.1
branch has been created specifically to host the Arabic localization efforts. The progress of this localization is being tracked through the following issues:#44682
#37546
What would you like to be added
Configure Netlify preview specifically for the
dev-1.29-ar.1
branch.Why is this needed
It is essential to have Netlify preview for the Arabic branch to facilitate the review process. This preview functionality will be particularly useful for identifying and addressing CSS issues related to right-to-left (RTL) layout, as Arabic is the first RTL language supported. For example, issues such as those outlined in the following PR and issue:
#46042
#45077
Comments
The Netlify preview will enable contributors and reviewers to visualize and discuss these issues directly within the context of pull requests, enhancing the efficiency and effectiveness of the localization efforts.
Slack discussion : https://kubernetes.slack.com/archives/C1J0BPD2M/p1714297094044239
The text was updated successfully, but these errors were encountered: