Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gcr.io/google-containers still used in current docs #49523

Open
BenTheElder opened this issue Jan 22, 2025 · 7 comments
Open

gcr.io/google-containers still used in current docs #49523

BenTheElder opened this issue Jan 22, 2025 · 7 comments
Assignees
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.

Comments

@BenTheElder
Copy link
Member

This is a Bug Report

Problem:

There are still apparently active docs using this outdated image host, it should be replaced by registry.k8s.io which has all images + newer ones and is controlled fully by the community.
https://cs.k8s.io/?q=gcr.io%2Fgoogle-containers&i=nope&files=&excludeFiles=&repos=kubernetes/website

Proposed Solution:

I suspect we shouldn't touch the blog posts, but should update:

content/en/docs/tasks/debug/debug-application/debug-service.md

Page to Update:
https://kubernetes.io/docs/tasks/debug/debug-application/debug-service/

@BenTheElder BenTheElder added the kind/bug Categorizes issue or PR as related to a bug. label Jan 22, 2025
@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 22, 2025
@BenTheElder
Copy link
Member Author

k8s.gcr.io should be replaced as well.

I was going to file a PR for this, but I'm not sure if we want to keep using this unpatched busybox image.

Maybe agnhost again?

@thisisharrsh
Copy link
Contributor

/sig docs

@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Jan 22, 2025
@thisisharrsh
Copy link
Contributor

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 22, 2025
@sftim
Copy link
Contributor

sftim commented Jan 22, 2025

/triage accepted
/priority important-longterm

@k8s-ci-robot k8s-ci-robot added triage/accepted Indicates an issue or PR is ready to be actively worked on. priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. and removed needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jan 22, 2025
@iheartNathan
Copy link
Contributor

/assign

@BenTheElder
Copy link
Member Author

I was going to file a PR for this, but I'm not sure if we want to keep using this unpatched busybox image.

Maybe agnhost again?

Anyone have thoughts on this? Technically we could just file a trivial "replace gcr.io/google-containers with registry.k8s.io", but any image that was on gcr.io/google-containers is really old / unpatched, and we aren't currently maintaining busybox image for any project.

SIG Testing has previously offered up agnhost image for this sort of debugging, but it is technically developed for e2e testing Kubernetes. It is however actively maintained / published. It may not be drop-in compatible depending on usage.

@stmcginnis
Copy link
Contributor

+1 for agnhost for me. Forcing some minor tweaks to work with the new image seems better to me than having everyone use an old and unpatched image. IIRC there were some arm64 compatibility concerns as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. language/en Issues or PRs related to English language priority/important-longterm Important over the long term, but may not be staffed and/or may need multiple releases to complete. sig/docs Categorizes an issue or PR as relevant to SIG Docs. triage/accepted Indicates an issue or PR is ready to be actively worked on.
Projects
None yet
Development

No branches or pull requests

6 participants