Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue with k8s.io/docs/reference/kubectl/generated/kubectl_drain/ - Links are weird #49597

Open
szilard-nemeth opened this issue Jan 29, 2025 · 8 comments
Assignees
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.

Comments

@szilard-nemeth
Copy link

In the beginning of the Synopsis, quoting:

Drain node in preparation for maintenance.
The given node will be marked unschedulable to prevent new pods from arriving. 'drain' evicts the pods if the API server supports https://kubernetes.io/docs/concepts/workloads/pods/disruptions/ eviction https://kubernetes.io/docs/concepts/workloads/pods/disruptions/ .

I don't think those 2 links should look like this.
Thanks

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label Jan 29, 2025
@utkarsh-singh1
Copy link
Contributor

Thanks for the report @szilard-nemeth, there seems to be 2 links pointing to the same location.

@utkarsh-singh1
Copy link
Contributor

Since both the mentioned page is auto-generated page it could only be fixed in the kubernetes/kubernetes repository.

/language en

@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Jan 30, 2025
@sftim
Copy link
Contributor

sftim commented Jan 31, 2025

Since both the mentioned page is auto-generated page it could only be fixed in the kubernetes/kubernetes repository.

We could also fix the code that generates the docs. This calls for a contributor skilled in Golang coding; we only have a few folk in this SIG with an interest in Golang.
If anyone wants to learn more, ask in #sig-contribex on Kubernetes Slack. The Kubernetes project overall has a large number of contributors who can write in Go.

@Aaina26
Copy link
Contributor

Aaina26 commented Jan 31, 2025

Hi I would like to try and fix this...assigning myself
/assign

@sftim
Copy link
Contributor

sftim commented Jan 31, 2025

@Maalvi14
Copy link

Maalvi14 commented Feb 1, 2025

Hi I have experience in Golang and could help @Aaina26 on this issue
/assign

@sftim
Copy link
Contributor

sftim commented Feb 1, 2025

@Maalvi14 please considering starting a thread in Kubernetes' Slack workspace around this work. We'd love to support you and @Aaina26 on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one.
Projects
None yet
Development

No branches or pull requests

6 participants