Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GlobalCP Health Card: Make numbers of things more clear/explanatory #2667

Open
johncowen opened this issue Jun 20, 2024 · 1 comment · May be fixed by #3490
Open

GlobalCP Health Card: Make numbers of things more clear/explanatory #2667

johncowen opened this issue Jun 20, 2024 · 1 comment · May be fixed by #3490
Assignees
@schogges
Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@johncowen
Copy link
Contributor

Description

In the below screenshot we use various colors for certain numbers, but its not super clear why.

Maybe we should use tooltips or similar to explain what these numbers are/why they are colored.

Screenshot 2024-06-20 at 16 31 35
@johncowen johncowen added triage/pending This issue will be looked at on the next triage meeting kind/feature New feature labels Jun 20, 2024
@slonka slonka added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Jun 24, 2024
@johncowen johncowen added this to the 2.9.x milestone Jul 4, 2024
@johncowen
Copy link
Contributor Author

On re-reading this again, do we even want to use coloring here? Does it actually "mean" anything?

Looking at the code it looks to use a simple ratio of "if less than 50% are online use red, otherwise if less than 100% are online use yellow".

The thing is, who's to say that my cluster is only "in danger" if less than half of my services are online? Surely I might want to be "in danger" if any single service is not online?

Alternatively, if I have 5 services with 10 dataplanes/instances, I'm probably running perfectly fine if half of my dataplanes/instances are offline because each still has 5 instances available.

I'd almost be fine using (or something similar)

Zones             | Meshes | Services       | Data Plane Proxies
2 of 11 online    | 93     | 1 of 6 online  | 17 of 23 online

We have the space to do that here.

Anyway mainly food for thought.

@johncowen johncowen modified the milestones: 2.9.x, 2.10.x Sep 9, 2024
@johncowen johncowen mentioned this issue Dec 16, 2024
Merged
This was referenced Jan 23, 2025
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@schogges schogges

Labels
kind/feature New feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

Successfully merging a pull request may close this issue.

feat(vcp-health): add policies, show totals only, hide border on wrapped items schogges/kuma-gui
3 participants
@johncowen @slonka @schogges