Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal with MeshService should not require kuma.io/service #12753

Open
lukidzi opened this issue Feb 4, 2025 · 1 comment
Open

Universal with MeshService should not require kuma.io/service #12753

lukidzi opened this issue Feb 4, 2025 · 1 comment
Labels
kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Feb 4, 2025

Description

While testing MeshService on Universal, I noticed that even though MeshService is supposed to work without requiring kuma.io/service, there is currently no way to support this. The dataplane validator enforces the presence of kuma.io/service and later generates a MeshService using its value as the name. Additionally, if we manually create a MeshService to select a specific dataplane with the same name as kuma.io/service, a conflict occurs because the generator attempts to create a MeshService with kuma.io/service

How should we behave?
Maybe instead of using kuma.io/service, we should generate a MeshService using the name of the dataplane and all its inbound ports, rather than relying on kuma.io/service?

@lukidzi lukidzi added kind/design Design doc or related kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting labels Feb 4, 2025
@lukidzi
Copy link
Contributor Author

lukidzi commented Feb 10, 2025

Triage: we are using kuma.io/sevice for certificates and over multiple places. We should probably work on identity of the dataplane

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting kind/improvement Improvement on an existing feature labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/design Design doc or related triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Development

No branches or pull requests

1 participant