Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

kumactl should suggest listing new policies #12770

Open
lukidzi opened this issue Feb 6, 2025 · 1 comment
Open

kumactl should suggest listing new policies #12770

lukidzi opened this issue Feb 6, 2025 · 1 comment
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it

Comments

@lukidzi
Copy link
Contributor

lukidzi commented Feb 6, 2025

Description

When a user enters the docs, we don't show the old (source-destination) policies by default. However, later, when the user retrieves policies using kumactl, all options are displayed, which might be confusing.

Docs
Image

Kumactl

Image

Ideas:

  1. Introduce flag --legacy/--deprecated to show old policies
  2. Add log once listing kumactl get rate-limit > this policy id deprecated. Did you mean MeshRateLimit?
  3. Leave it as it is
@lukidzi lukidzi added kind/improvement Improvement on an existing feature triage/pending This issue will be looked at on the next triage meeting labels Feb 6, 2025
@lukidzi
Copy link
Contributor Author

lukidzi commented Feb 10, 2025

Triage: maybe we can introduce a flag to show old policies. We can also check if cli has some deprecated feature to deprecate specific command.

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
kind/improvement Improvement on an existing feature triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lukidzi