Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MMZS allowed to have longer names than MeshService and MeshExternalService #12825

Open
lobkovilya opened this issue Feb 11, 2025 · 3 comments
Open

MMZS allowed to have longer names than MeshService and MeshExternalService #12825

lobkovilya opened this issue Feb 11, 2025 · 3 comments
Labels
triage/accepted The issue was reviewed and is complete enough to start working on it
Milestone
2.10.x

Comments

@lobkovilya
Copy link
Contributor

Description

MeshService and MeshExternalService names are limited to 63 characters, but MeshMutliZoneService can be 253.
@lobkovilya lobkovilya added kind/feature New feature triage/pending This issue will be looked at on the next triage meeting and removed kind/feature New feature labels Feb 11, 2025
@lobkovilya
Copy link
Contributor Author

@michaelbeaumont you added the validation for MS and MES probably when we didn't have MMZS. Do you know if it's needed for MMZS?

@lukidzi lukidzi added triage/accepted The issue was reviewed and is complete enough to start working on it and removed triage/pending This issue will be looked at on the next triage meeting labels Feb 17, 2025
@lukidzi
Copy link
Contributor

lukidzi commented Feb 17, 2025

Triage: If there is a good reason to keep 253 let's write it. If there is no reason to keep it, we should disallow creating new services MMZS with longer names than 63 and still supporting backward compatibility.

@lukidzi lukidzi added this to the 2.10.x milestone Feb 17, 2025
@michaelbeaumont
Copy link
Contributor

No, no reason not to have 63

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
triage/accepted The issue was reviewed and is complete enough to start working on it
Projects
None yet
Milestone
2.10.x
Development

No branches or pull requests
3 participants
@michaelbeaumont @lobkovilya @lukidzi