You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The proposal creation function still iterates congruently, but the expected node id is not what is expected. All tests pass now, but this is was the bug. It didn't stop proposal generation for nodes, but it chose the wrong participant to create the next proposal
where we add \(1\) to \(B_i\) to represent the next block id, and we add \(1\) to the result assuming node ids, \(N_{id}\) begin at \(1\), not \(0\). The node then checks for whether or not its own node id, \(N_{id}\), is equal to the result of \texttt{PCE}. Effectively, this is checking whether or not \(N_{id}\) is congruent to the next \(B_i\) modulo the cardinality of nodes being considered or proposal creation, \(\vert N \vert\).
\begin{equation}
N_{id} = (B_i +1) \: (\texttt{mod} \:\vert N \vert)
\end{equation}
Should be:
\begin{equation}
\texttt{PCE} := (B_i \:\texttt{mod} \:\vert N \vert) + 1 \end{equation}
\hspace*{15pt}
where we add \(1\) to the result assuming node ids, \(N_{id}\) begin at \(1\), not \(0\). The node then checks for whether or not its own node id, \(N_{id}\), is equal to the result of \texttt{PCE}. Effectively, this is checking whether or not \(N_{id}\) is congruent to the next \(B_i\) modulo the cardinality of nodes being considered or proposal creation, \(\vert N \vert\).
\begin{equation}
N_{id} = B_i \: (\texttt{mod} \:\vert N \vert) \end{equation}
Because
[print( ( (x+1) % (3+1) ) +1 ) forxinrange(0,10)]
2
3
4
1
2
3
4
1
2
3
but this is correct
[print((x%3) +1) forxinrange(0,10)]
1
2
3
1
2
3
1
2
3
1
This works for three, and for 2 peers
[print((x%2) +1) forxinrange(0,10)]
1
2
1
2
1
2
1
2
1
2
and for 5 peers
[print((x%5) +1) forxinrange(0,10)]
1
2
3
4
5
1
2
3
4
5
The update will be made on in the aos repo as well
The text was updated successfully, but these errors were encountered:
The proposal creation function still iterates congruently, but the expected node id is not what is expected. All tests pass now, but this is was the bug. It didn't stop proposal generation for nodes, but it chose the wrong participant to create the next proposal
aos-paper/aos.tex
Lines 343 to 353 in bdf32e5
Should be:
Because
but this is correct
This works for three, and for 2 peers
and for 5 peers
The update will be made on in the aos repo as well
The text was updated successfully, but these errors were encountered: