Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved tree shaking? #70

Open
kylebarron opened this issue Dec 3, 2023 · 1 comment
Open

Improved tree shaking? #70

kylebarron opened this issue Dec 3, 2023 · 1 comment

Comments

@kylebarron
Copy link
Owner

I previously found that importing from * as arrow meant that esbuild couldn't treeshake at all. geoarrow/geoarrow-js#20

So maybe this lib should use path imports? It does have to import every type necessarily because it doesn't know what data type the C struct will be.
@kylebarron
Copy link
Owner Author

It should be possible to try this and see how much the output rollup sizes change

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@kylebarron