Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KIM Integration - redesign configuration after migration is done #1241

Open
4 tasks
jaroslaw-pieszka opened this issue Oct 2, 2024 · 3 comments
Open
4 tasks
Assignees

Comments

@jaroslaw-pieszka
Copy link
Contributor

When we use KIM only, provisioner is no longer used, we need to simplify and unify configuration.

To many steps we pass separately input.Config and broker.KimConfig objects.

AC:

  • we pass one configuration object to all steps that need it
  • there are no longer provisioner related settings (this is in scope of different ticket)
  • KIM migration related settings are removed
  • some previously used settings become KIM related and possible should be moved to kim section
@jaroslaw-pieszka
Copy link
Contributor Author

Blocked till migration is done.

@jaroslaw-pieszka
Copy link
Contributor Author

Following configuration values should be migrated to kim section (are used to create Runtime CRs`:

  • Provisioner.KubernetesVersion
  • Provisioner.DefaultGardenerShootPurpose
  • Provisioner.MachineImage
  • Provisioner.MachineImageVersion
  • Provisioner.DefaultTrialProvider
  • Provisioner.MultiZoneCluster
  • Provisioner.ControlPlaneFailureTolerance

We could consider moving:

  • Broker.UseSmallerMachineTypes to kim section

Following values should be moved to other place (possible section with timeouts - there are more timeouts settings scattered):

  • Provisioner.ProvisioningTimeout
  • Provisioner.DeprovisioningTimeout
  • Provisioner.RuntimeResourceStepTimeout
  • Provisioner.ClusterUpdateStepTimeout

Following values should be removed (double check before actual removal):

  • Provisioner.URL
  • Provisioner.TrialNodesNumber
  • Provisioner.AutoUpdateKubernetesVersion
  • Provisioner.AutoUpdateMachineImageVersion
  • Provisioner.EnableShootAndSeedSameRegion

Removal is blocked until provisioner is decommissioned and only KIM is driving/controlling the process.

@jaroslaw-pieszka
Copy link
Contributor Author

jaroslaw-pieszka commented Oct 14, 2024

This is blocked by #1187 and #1298

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant