Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused nolint:gochecknoglobals in v1beta1, v1beta2 packages #1433

Open
c-pius opened this issue Mar 26, 2024 · 0 comments · May be fixed by #1999
Open

Unused nolint:gochecknoglobals in v1beta1, v1beta2 packages #1433

c-pius opened this issue Mar 26, 2024 · 0 comments · May be fixed by #1999
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@c-pius
Copy link
Contributor

c-pius commented Mar 26, 2024

Description

v1beta1 and v1beta2 have nolint:gochecknoglobals. However, when removing them, the linter doesn't complain, so they either may be unnecessary, or the linter is misconfigured. We need to find out what the reason for this is.

Sidequest: find out if there is a possibility to return linting errors when there are unused /nolint

Steps to reproduce

  • remove either of the lines linked above
  • run make lint
  • observe that no linting error is produced

Environment Type

Managed

Environment Info

Kubernetes Version: x.y.z
Docker Version: x.y.z
Kyma CLI Version: x.y.z
If used - k3d/k3s/minikube versions

Attachments

No response

@c-pius c-pius added the kind/bug Categorizes issue or PR as related to a bug. label Mar 26, 2024
@nesmabadr nesmabadr self-assigned this Oct 30, 2024
@nesmabadr nesmabadr linked a pull request Oct 30, 2024 that will close this issue
@nesmabadr nesmabadr removed their assignment Oct 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants