Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image builder binary tests does not check github outputs values #11134

Open
1 task
dekiel opened this issue Jun 25, 2024 · 0 comments
Open
1 task

Image builder binary tests does not check github outputs values #11134

dekiel opened this issue Jun 25, 2024 · 0 comments
Labels
area/ci Issues or PRs related to CI related topics image-builder kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario.

Comments

@dekiel
Copy link
Contributor

dekiel commented Jun 25, 2024

Description

A unit tests covers a function extracting built images from ado logs. The tests doesn't check if the images are correctly extracted in the context of whole application execution. Tests should validate if image-builder execution in github action sets expected values.

Reasons

User reported a bug with empty images GitHub output, which was caused by passing an empty value of logs variable to the extractImagesFromADOLogs function. See #11132

Acceptance Criteria

  • Image Builder binary tests validates GitHub outputs values in the context of whole application run
@dekiel dekiel added area/ci Issues or PRs related to CI related topics kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario. labels Jun 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci Issues or PRs related to CI related topics image-builder kind/missing-test Categorizes issue or PR as related to missing automated tests for scenario.
Projects
None yet
Development

No branches or pull requests

1 participant