Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle NApp requirement #267

Open
diraol opened this issue Jun 28, 2017 · 3 comments
Open

Handle NApp requirement #267

diraol opened this issue Jun 28, 2017 · 3 comments

Comments

@diraol
Copy link
Contributor

diraol commented Jun 28, 2017

How to deal with the NApp requirements.txt file, speacially regarding kytos package version.

@cemsbr
Copy link
Contributor

cemsbr commented Aug 3, 2017

@diraol, maybe we have already discussed this: python packages in README and NApp deps in kytos.json.

@diraol
Copy link
Contributor Author

diraol commented Aug 4, 2017

@cemsbr I think that we defined that non-python packages dependencies should be documented on the NApp README. But for python packages this is not strictly necessary, since we can install the NApp python dependencies by checking the NApp requirements.txt file. May be we can install them by just using pip to do it.

@cemsbr
Copy link
Contributor

cemsbr commented Aug 8, 2017

That would be easy if there were only virtual environments. However, the way it is now, it is possible to have Kytos installed by root and a user willing to install a NApp, with all the corner cases.

Besides, think about a NApp using version x of a Python package and another using version y. In such cases, only one virtualenv per NApp could solve the problem.

For now, a quick and (sometimes) useful solution is to try pip install -r requirements.txt like @diraol suggested, and warn the user if it fails for any reason (permission, compilation, etc).

What do you think, @beraldoleal?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants