Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add session idle checker into Session Detail Panel #3062

Open
yomybaby opened this issue Jan 21, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3061
Open

Add session idle checker into Session Detail Panel #3062

yomybaby opened this issue Jan 21, 2025 — with Lablup-Issue-Syncer · 0 comments · Fixed by #3061
Assignees

Comments

@yomybaby
Copy link
Member

Add the Idle Checker to the Session Detial Panel. By default, it takes the same idle checker UI shown in backend-ai-session-list.

@yomybaby yomybaby changed the title idle checks Add session idle checker into Session Detail Panel Jan 21, 2025
graphite-app bot pushed a commit that referenced this issue Feb 7, 2025
resolves #3062 (FR-250)
<!-- replace NNN, MMM with the GitHub issue number and the corresponding Jira issue number. -->

<!--
Please precisely, concisely, and concretely describe what this PR changes, the rationale behind codes,
and how it affects the users and other developers.
-->
>The issues below will be addressed as separate issues.
> - Utilization checks should add heterogeneity support, currently only checks for cuda and ipu devices.
> - Utilization checks should return the device key as the key of the device metadata.
> - The session end time calculated by the idle checker is �returned as remaining (sec) and calculated on the client side, which may cause an error from the actual calculated value.

**Changes:**
- Provide idle check information in the session details panel.
- Fixed `SessionDetailContent` to use fetchKey of `SessionDetailDrawer` as controllableState for refetch session data via session status.
- Sends an interval network request to update the information in the idle checker.
- Displays an alert at the top of the drawer when the session end time, as calculated by the Idle checker, is imminent.

**How to test:**
- Enable idle checker on the resource policy page of the control panel.
- You can set the session end time through the session lifetime and idle timeout settings in the keypair resource policy.
- (Control Panel Only) You can set the session end time throught the Time window setting in the idle checker setting modal.
- Shows the idle check column only for "RUNNING" status sessions. Verify that the column is not visible for sessions in other statuses.
- No timer is provided for options that are not enabled in idle checker (idle checker has Network Idle Timeout, Utilization checker, and Session lifetime fields).

**Checklist:** (if applicable)

- [ ] Documentation
- [ ] Minium required manager version
- [ ] Specific setting for review (eg., KB link, endpoint or how to setup)
- [ ] Minimum requirements to check during review
- [ ] Test case(s) to demonstrate the difference of before/after
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants