Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.72 Bug unable to save channel data #83

Open
austinc-s opened this issue Dec 9, 2021 · 3 comments
Open

0.72 Bug unable to save channel data #83

austinc-s opened this issue Dec 9, 2021 · 3 comments

Comments

@austinc-s
Copy link

  1. Saving the channel data to database does not work on 0.72.
    Steps:
  • Make changes to channel intensity and color
  • Save to database
  • Load new sample
  • Load original sample again
  • Bug: Loading channel settings from database does not work, all settings back at default
  1. Saving the channel data to .csv does not work on 0.72.
    Steps:
  • Make changes to channel intensity and color
  • Error: 500 Internal Server Error results from trying to save channel data as a .csv

System Info:
Windows 11 build 22000.348
Microsoft Edge (Chromium) 96.0.1054.43
Data is log1p transformed upon import

@kruegert
Copy link
Member

kruegert commented Dec 9, 2021

Ouch. Thanks. We will have a look.

@kruegert
Copy link
Member

kruegert commented Dec 14, 2021

I could reproduce the error under Windows using the latest version 072 using the 163 core dataset. Error appears in both cases: log transformed and raw data.

Server says:

ON SAVING:
ERROR:minerva_analysis:Exception on /save_channel_list [POST]
Traceback (most recent call last):
File "flask\app.py", line 2447, in wsgi_app
File "flask\app.py", line 1952, in full_dispatch_request
File "flask\app.py", line 1821, in handle_user_exception
File "flask_compat.py", line 39, in reraise
File "flask\app.py", line 1950, in full_dispatch_request
File "flask\app.py", line 1936, in dispatch_request
File "minerva_analysis\server\routes\data_routes.py", line 263, in save_channel_list
data_model.save_channel_list(datasource, map_channels, active_channels, list_colors, list_ranges, list_channels)
File "minerva_analysis\server\models\data_model.py", line 591, in save_channel_list
arr.append([channel_name, list_channels[channel_name][0], list_channels[channel_name][1], 255, 255, 255, 1, False])
KeyError: 'DNA1'

ON LOADING:
ERROR:minerva_analysis:Exception on /get_saved_channel_list [GET]
Traceback (most recent call last):
File "flask\app.py", line 2447, in wsgi_app
File "flask\app.py", line 1952, in full_dispatch_request
File "flask\app.py", line 1821, in handle_user_exception
File "flask_compat.py", line 39, in reraise
File "flask\app.py", line 1950, in full_dispatch_request
File "flask\app.py", line 1936, in dispatch_request
File "minerva_analysis\server\routes\data_routes.py", line 291, in get_saved_channel_list
resp = data_model.get_saved_channel_list(datasource)
File "minerva_analysis\server\models\data_model.py", line 610, in get_saved_channel_list
return pickle.loads(channel_list.cells)
AttributeError: 'NoneType' object has no attribute 'cells'

Nhan, probably related to your changes in DataModel line 590 and 591.
image

when I debug it, it seems the list_channes array has the full name as indices but you want to access it with short names:
image

causing a key error:
KeyError: 'DNA1'

@nchuynh
Copy link
Member

nchuynh commented Dec 15, 2021

Thanks Austin for reporting this issue and thanks Robert for info on the error.

There was a discrepancy in the channel names used for saving the data and uploading the data.

We fixed this issue in the latest release (v0.73_gating), please let us know if you still have issues saving the channel data. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants