Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Badges will not get updated and builds will remain in pending #25

Open
gellweiler opened this issue Mar 24, 2019 · 1 comment
Open

Badges will not get updated and builds will remain in pending #25

gellweiler opened this issue Mar 24, 2019 · 1 comment

Comments

@gellweiler
Copy link

I was able to setup lambci + lambci-ecs so that builds will build in ecs. The build status is correctly updated on github commits and slack messages are sent.
Badges and build logs don't get updated with the results.
Currently the ecs container directly notifies slack and github when the build is finished, wouldn't it be a better design if the ecs container would trigger the build-lambci function on finish instead and that would take care of finishing the build?

@gellweiler
Copy link
Author

I've created a PR that will update badges and logs for ecs builds using the status event from github. Also it will fix the issue that the lambda will timeout for ecs builds.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant