Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Different handling of dynamic layout between cairo_lang & cairo_vm #1650

Open
fmoletta opened this issue Mar 5, 2024 · 2 comments
Open

Different handling of dynamic layout between cairo_lang & cairo_vm #1650

fmoletta opened this issue Mar 5, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@fmoletta
Copy link
Member

fmoletta commented Mar 5, 2024

In cairo_vm, setting the layout to dynamic sets the builtin's ratios to None & sets all other layout parameters to a constant value. In cairo_lang, setting the layout to dynamic forces you to also submit a json file with the layout params. We should investigate how this is handled in cairo_lang to ensure the same behaviour

@fmoletta fmoletta added the bug Something isn't working label Mar 5, 2024
@juanbono
Copy link
Member

This will be addressed by #1716

@fmoletta
Copy link
Member Author

This will be addressed by #1716

Its a different issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants